Add state metric to windows services #21830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briantu
added
qa/skip-qa
Codecov Report❌ Patch coverage is Additional details and impacted files🚀 New features to boost your workflow:
|
janine-c
approved these changes
Nov 4, 2025
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
|
The following files, which will be shipped with the agent, were modified in this PR and You can ignore this if you are sure the changes in this PR do not require QA. Otherwise, consider removing the label. List of modified files that will be shipped with the agent |
julien-lebot
approved these changes
Nov 7, 2025
Contributor
julien-lebot
left a comment
julien-lebot
left a comment
There was a problem hiding this comment.
Left some minor comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added a new
windows_service.statemetric which always emits 1 and is tagged withwindows_service_state. This allows the user to create timeseries graphs that can filter the windows services by state.Motivation
https://datadoghq.atlassian.net/browse/WINA-2011
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged